Skip to content

Make system options great again#131

Merged
ChinemeremChigbo merged 2 commits intomainfrom
colin/system-options-edit
Apr 19, 2025
Merged

Make system options great again#131
ChinemeremChigbo merged 2 commits intomainfrom
colin/system-options-edit

Conversation

@ColinToft
Copy link
Contributor

@ColinToft ColinToft commented Apr 18, 2025 •
edited
Loading

Notion Ticket

Ticket Name

Summary & Review Focus

  • Removed check/cancel buttons, removed border around text boxes
  • Blue border around item being edited or added
  • click outside to save, except if adding an item and no info has been filled in -> cancel adding row

Testing Instructions

Checklist

  • PR title is descriptive and in imperative tense
  • Commit messages are descriptive, atomic, and follow best practices
  • Linter(s) have been run
  • Requested reviews from the PL and relevant team members

@vercel
Copy link

vercel bot commented Apr 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2025 1:41am

@ColinToft ColinToft self-assigned this Apr 18, 2025
ChinemeremChigbo
ChinemeremChigbo approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Greatest.

@ChinemeremChigbo ChinemeremChigbo merged commit 1c0c5c6 into main Apr 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChinemeremChigbo ChinemeremChigbo ChinemeremChigbo approved these changes

Assignees

@ColinToft ColinToft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ColinToft @ChinemeremChigbo